No SettingWithCopyWarning on groupby results #19152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dataframe referred to in the warning is a result of an internal slicing operation and should not lead to a warning in userspace. fixes pandas-dev#19151
|
see my comments on the issue. This is as expected. mutation is non-idiomatic, and this is a correct warning. If you really really want to mutate, you must copy first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataframe referred to in the warning is a result of an
internal slicing operation and should not lead to a warning
in userspace.
git diff upstream/master -u -- "*.py" | flake8 --diff