Skip to content

added pd as namespace #12608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added pd as namespace #12608

wants to merge 1 commit into from

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Mar 13, 2016

This is the msg:
more consistent with code in the rest of the document

added more namespace

Generally, also numpy's randn should used as
np.random.randn

isolated namespace changes

Note:
I hope I got the rebase & merge right.

@@ -2895,6 +2895,24 @@ everything in the sub-store and BELOW, so be *careful*.

.. _io.hdf5-types:

.. warning:: Hierarchical keys cannot be retrieved as dotted (attribute) access as described above for items stored under root node.

.. ipython:: python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls take this out. This is a completly separate issue that we may or may not include.

@@ -1475,7 +1475,7 @@ Writing to a file, with a date index and a date column
dfj2['date'] = Timestamp('20130101')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these remainings are intentional? Pls change others and remove from pandas import *.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this was not my change.
Something must habe gotten confused.

@jreback
Copy link
Contributor

jreback commented Mar 14, 2016

@dacoex no, @sinhrks is asking if you can make that change. should be straightforward.

@dacoex
Copy link
Contributor Author

dacoex commented Mar 14, 2016

Ah, OK. will do.

more consistent with code in the rest of the document

added more namespace

Generally, also numpy's randn should used as
np.random.randn

isolated namespace changes

removed warning on hdf groups

remaining namespace
@jreback
Copy link
Contributor

jreback commented Mar 20, 2016

pls build the docs. This makes most things actually fail as there are lots of additional imports that are needed (or pd.) pre-pended

@jreback
Copy link
Contributor

jreback commented Apr 1, 2016

@dacoex can you update

@dacoex
Copy link
Contributor Author

dacoex commented Apr 23, 2016

Sorry, I'd been busy with some other items off the coding domain.
What shall I update?
Reference:
#12608 (comment)

@@ -3127,7 +3126,7 @@ specified in the format: ``<float>(<unit>)``, where float may be signed (and fra
.. ipython:: python

from datetime import timedelta
dftd = DataFrame(dict(A = Timestamp('20130101'), B = [ Timestamp('20130101') + timedelta(days=i,seconds=10) for i in range(10) ]))
dftd = pd.DataFrame(dict(A = Timestamp('20130101'), B = [ Timestamp('20130101') + timedelta(days=i,seconds=10) for i in range(10) ]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so since you eliminated the from pandas import * you need to build the docs and you will see failures, eg. pd.Timestamp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. OK, thanks for the hint.

@jreback
Copy link
Contributor

jreback commented May 7, 2016

can you rebase and update

@jreback
Copy link
Contributor

jreback commented May 25, 2016

can you rebase / update?

@jreback
Copy link
Contributor

jreback commented May 26, 2016

pls reopen when you can update

@jreback jreback closed this May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants