Skip to content

BUG: Banklist.html was removed, failure on master #38988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phofl opened this issue Jan 6, 2021 · 4 comments · Fixed by #42889
Closed

BUG: Banklist.html was removed, failure on master #38988

phofl opened this issue Jan 6, 2021 · 4 comments · Fixed by #42889
Labels
CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Milestone

Comments

@phofl
Copy link
Member

phofl commented Jan 6, 2021

Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.

Code Sample, a copy-pastable example

The banklist.html file was removed from "https://www.fdic.gov/resources/resolutions/bank-failures/failed-bank-list/
#38987 marked the tests as xfail and removed the userguide entry.

Expected

Replace the xfail tests with a new html file url and adjust the userguide appropriately.

@phofl phofl added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 6, 2021
@jreback
Copy link
Contributor

jreback commented Jan 6, 2021

apparently this was just moved to a new URI.

@phofl
Copy link
Member Author

phofl commented Jan 6, 2021

The URL I posted above is the new one, but the html file is no longer there. It is now stored as a csv file

raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Jan 15, 2021
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
@john-sandall
Copy link

The current documentation here is a little confusing as of present: https://pandas.pydata.org/pandas-docs/stable/user_guide/io.html#reading-html-content

Read a URL with no options: references a new spam.html introduced in this commit (68db2d2) but then immediately below says Read in the content of the “banklist.html” file which is confusing.

I suspect this should either:

As a sidenote, I use this section for teaching regularly and reading from a url like https://raw.githubusercontent.com/pandas-dev/pandas/master/pandas/tests/io/data/html/banklist.html is "less real" for students, it looks like (and literally is) test data. The previous example was great because it referenced a real website, people can go to https://www.fdic.gov/resources/resolutions/bank-failures/failed-bank-list/ and see an HTML table in one place, and then the same data in a pandas DataFrame. People love this the first time they do it.

It'd be nice to reference https://www.fdic.gov/resources/resolutions/bank-failures/failed-bank-list/ or otherwise something like https://en.wikipedia.org/wiki/List_of_countries_and_dependencies_by_population for this part of the docs.

@phofl
Copy link
Member Author

phofl commented Feb 28, 2021

Could you provide a PR for this?

@jreback jreback added this to the 1.4 milestone Sep 1, 2021
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Dec 24, 2021
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Jan 16, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Feb 6, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Mar 12, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Apr 18, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Jul 14, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this issue Nov 20, 2022
Origin: loosely based on upstream commit 68db2d26ddb5f95de4254d61b850d3dcaf6ce717
Author: patrick "phofl", Rebecca N. Palmer <[email protected]>
Bug: pandas-dev/pandas#38988
Bug-Debian: https://bugs.debian.org/979621
Forwarded: no


Gbp-Pq: Name 979621_dead_url.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants