Restore pthread LDFLAG in examples #3229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Restore the
pthread
LDFLAG
to build the following examples:multithread
&reading_logs_with_offset
why
I removed this flag from the
reading_logs_with_offset
in commit 293cd21 after replacing usage ofpthreads
with C++'sstd::thread
. Additionally, I didn't add that flag either to themultithread
example added in commit 4bf9616 for the same reason.However, I'm getting the following error when building both of these projects in a Debian container:
NOTE: It's curious that this doesn't happen when building the projects in all the non-Windows environments of the
Quality Assurance
workflow (which uses the same configuration) and thus wasn't detected before integrating PR #3216. 🤷♂️