fix logging issues #1997
Closed
fix logging issues #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_security does not allow per-module log level configuration nor to log module information into error_log. For example, following does not work
LogLevel security2:infoErrorLogFormat "{"\"module\":\"%m\", \"level\":\"%l\", \"message\":\"%M\"}"In the later example no module information is logged. Commit 1f4b951 fixes these issues.
In addition, custom log formats are not applied for messages being logged at startup. Commit b9e8317 fixes some (even though not all) log messages where only the default log format is applied.
Please note that there are more log messages having that problem but that would need far-reaching changes. For example in the function msc_status_engine_call() that is also used by standalone/api.c where no server_rec is available.