Exit more gracefully if uri length is zero #173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defanator
reviewed
Jan 29, 2020
| @@ -150,6 +150,10 @@ ngx_http_modsecurity_rewrite_handler(ngx_http_request_t *r) | |||
| if (n_uri == (char*)-1 || n_method == (char*)-1) { | |||
There was a problem hiding this comment.
I'm not sure whether the better way is to change this check in a way like if (n_uri == NULL || n_method == NULL)?
There was a problem hiding this comment.
Assuming we want to leave the utility function ngx_str_to_char unchanged, it effectively has two different error return values: NULL, and (char *)-1. In that case it's useful to retain the existing line 150 check ... but then in addition also check for n_uri == NULL (the error use case that was occurring in owasp-modsecurity/ModSecurity#2216). We could of course also add a check for n_method==NULL, but I was focussed solely on improving the error handling for the case that we actually saw.
|
This is merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.