Inherit ARGs across stages that are based other stages #304
Conversation
openshift-ci
bot
added
the
approved
When a stage is based on another stage, that dependent stage should inherit ARGs and their values which were declared in the previous stage. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
inherit-args-across-stages
branch
from
1d24c5a to
f9175ff
Compare
|
LGTM |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@flouthoc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The "master" branch in github.com/openshift/origin was recently renamed to "main", so a number of URLs we used to test ADD's ability to fetch documents over https started failing because those URLs were no longer correct. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
When is this PR expected to be merged? |
When a stage is based on another stage, that dependent stage should inherit ARGs and their values which were declared in the previous stage. Should resolve containers/buildah#5762.