ci: remove --timings flag for Next.js repo e2e tests
#2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem to provide any value for us. It just adds some test run time and instability to our suite, since this ends up attempting to read a `test-timings.json` file from disk (fails every time) and then makes a request to fetch timings data from a private Vercel endpoint, which sometimes fails with a 403 for some reason.
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
approved these changes
May 8, 2025
|
Removed the tag so that the tests don't run again when we update the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't seem to provide any value for us. It just adds some test run time and instability to our suite, since this ends up attempting to read a
test-timings.jsonfile from disk (fails every time) and then makes a request to fetch timings data from a private Vercel endpoint, which sometimes fails with a 403 for some reason.Documentation
N/A
Tests
N/A
Relevant links (GitHub issues, etc.) or a picture of cute animal
It was added here without explanation: https://github.com/netlify/next-runtime-minimal/pull/334/commits/7ea73a2c7c6be6a898bdc6174e09a8198848a1cb