Skip to content

update the otlp exporter configuration #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2021
Merged

update the otlp exporter configuration #899

merged 1 commit into from
Nov 11, 2021

Conversation

cuichenli
Copy link
Contributor

As per the issue open-telemetry/opentelemetry-collector-contrib#5377, the example configuration is out dated as insecure is now under the tls node.

@cuichenli cuichenli requested a review from a team November 11, 2021 07:26
chalin
chalin approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on:

@chalin
Copy link
Contributor

chalin commented Nov 11, 2021

@open-telemetry/collector-approvers: could one of you approve?

@jpkrohling
Copy link
Member

LGTM

@chalin
Copy link
Contributor

chalin commented Nov 11, 2021

Thanks @jpkrohling!

@chalin chalin merged commit b7df6f8 into open-telemetry:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuichenli @chalin @jpkrohling