Capture server attributes for botocore API calls #3448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
These attributes are required for Generative AI spans (see semantic conventions).
These are recommended not required. Said that I remember the semconv to pass the port only if it's different than 443 (and openai-v2 matches that) but I don't see it in the published doc so LGTM.
xrmx
requested changes
Apr 28, 2025
|
@xrmx - I've added server/port assertions for the bedrock API calls as well. Thanks for pointing that out. |
xrmx
reviewed
Apr 29, 2025
...n/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/utils.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Apr 29, 2025
...ry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Apr 29, 2025
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
server.*span attributes to all botocore calls.server.address: endpoint name (eg.iam.amazonaws.com,ec2.us-west-2.amazonaws.com)server.port(eg.443(default) or custom if specified)Related issues:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
otelcolDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.