Skip to content

Add opentelemetry-instrumentation as a dependency for click & asyncclick #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

jomcgi
Copy link
Contributor

@jomcgi jomcgi commented Apr 26, 2025

Description

Using click / asyncclick instrumentation in a project that does not already depend on opentelemetry-instrumentation raises a module not found error.

Added opentelemetry-instrumentation as a dependency for click & asyncclick.

Fixes #3441

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally with tox
  • Tested in project that was previously raising the error

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jomcgi jomcgi force-pushed the bug-3441/add-missing-dep branch 2 times, most recently from 148a709 to 789f064 Compare April 26, 2025 15:59
@jomcgi jomcgi changed the title [WIP] Add opentelemetry-instrumentation dependency to asyncclick [WIP] Add missing dependency to click / asyncclick instrumentations Apr 26, 2025
Using click / asyncclick instrumentation in a project that does not
already depend on opentelemetry-instrumentation raises a module
not found error.

Added opentelemetry-instrumentation as a dependency for click &
asyncclick.
@jomcgi jomcgi force-pushed the bug-3441/add-missing-dep branch from 789f064 to fbe1c94 Compare April 26, 2025 16:04
@jomcgi jomcgi marked this pull request as ready for review April 26, 2025 16:07
@jomcgi jomcgi requested a review from a team as a code owner April 26, 2025 16:07
@jomcgi jomcgi changed the title [WIP] Add missing dependency to click / asyncclick instrumentations Add missing opentelemetry-instrumentation dependency to click / asyncclick instrumentations Apr 26, 2025
@jomcgi jomcgi changed the title Add missing opentelemetry-instrumentation dependency to click / asyncclick instrumentations Add opentelemetry-instrumentation as a dependency for click & asyncclick Apr 26, 2025
@xrmx xrmx merged commit c6cdbeb into open-telemetry:main Apr 28, 2025
720 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent dependencies in opentelemetry-instrumentation-asyncclick
3 participants