fixed: asyncpg connection params are a namedtuple

[privatwolke]

Follow-up on the apparently abbandonned #2114.
Closes #2114

Description

The asyncpg instrumentation attempts to fall back on using the database name as the span name in case the first argument to the instrumented method is falsey.

Any attempt to do so results in errors simliar to this (truncated traceback):

Traceback (most recent call last):
  File "/opt/venv/lib/python3.12/site-packages/asyncpg/pool.py", line 597, in fetch
    return await con.fetch(
           ^^^^^^^^^^^^^^^^
  File "/opt/venv/lib/python3.12/site-packages/opentelemetry/instrumentation/asyncpg/__init__.py", line 154, in _do_execute
    name = args[0] if args[0] else params.get("database", "postgresql")
                                   ^^^^^^^^^^
AttributeError: 'ConnectionParameters' object has no attribute 'get'

This has probably never worked since asyncpg defines the _params attribute as an instance of ConnectionParams
(https://github.com/MagicStack/asyncpg/blob/master/asyncpg/connection.py#L62) which is a NamedTuple instance and thus don't define get. The proper way of safely accessing properties on a NamedTuple is using getattr.

The only case that I've actually found which triggers this branch is if the supplied query is an empty string. This is something that causes an AttributeError for Connection.execute but is fine for fetch(), fetchval(), fetchrow() and executemany().

The tests have been expanded to check these cases. Also, more status code validation has been added where it was missing.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• docker-tests for asyncpg instrumentation extended and passed

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: privatwolke / name: Stephan Klein (2cb3fcf)
• ✅ login: xrmx / name: Riccardo Magliocchetti (5d33f72, 5e8e58a)

[tammy-baylis-swi]

Thanks @privatwolke for revisiting this especially with the added test coverage.

To get this check to pass, please could you run tox -e ruff on your local then commit the changes.

[privatwolke]

@tammy-baylis-swi - thanks for the quick review! I've updated the PR with the suggested changes and also added additional tests for the Cursor instrumentation. Code formatting should now pass as well ✨

[tammy-baylis-swi]

@tammy-baylis-swi - thanks for the quick review! I've updated the PR with the suggested changes and also added additional tests for the Cursor instrumentation. Code formatting should now pass as well ✨

Thanks for those! I've added more suggestions and just triggered another ci/cd run. Please have another look.

[tammy-baylis-swi]

Thank you @privatwolke ! Lgtm. We'll need more reviews from a repo Maintainer; feel free to bring this PR up in Slack and/or the Python SIG meeting (every Thurs 9am PT)

[privatwolke]

@xrmx Thanks for approving this, but I think something went wrong with the automerge. Should I rebase my branch on the base branch?