Skip to content

shift process management from Probe to Manager #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@ examples/kafka-go/producer/producer
examples/kafka-go/consumer/consumer

go.work*

opentelemetry-helm-charts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Suggested change
opentelemetry-helm-charts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder got created somehow, I think while I was running one of the generators. It shouldn't be committed, and it should be in our gitignore. I can open a separate PR for this change if you'd prefer

1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ OpenTelemetry Go Automatic Instrumentation adheres to [Semantic Versioning](http
- Upgrade OpenTelemetry semantic conventions to `v1.30.0`. ([#2032](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/2032))
- Modify how the pattern is fetch from `net/http.Request`.
Now it uses `Request.Pattern` instead of `Request.pat.str` unless using go1.22, which continue using `Request.pat.str`. ([#2090](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/2090))
- Process management has shifted from Probe methods to the Manager, internal Manifest type removed. ([#2029](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/2029))

### Removed

Expand Down
6 changes: 3 additions & 3 deletions internal/pkg/instrumentation/benchmark_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ func BenchmarkFilterUnusedProbes1000(b *testing.B) {
func benchmarkValidateProbeDependents(b *testing.B, count int) {
manager := &Manager{}

syms := make([]probe.FunctionSymbol, count)
syms := make([]*probe.Uprobe, count)

for i := 0; i < count; i++ {
syms[i] = probe.FunctionSymbol{
Symbol: strconv.Itoa(i),
syms[i] = &probe.Uprobe{
Sym: strconv.Itoa(i),
DependsOn: nil,
}
}
Expand Down
Loading
Loading