Update Kubernetes example to latest version #4371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## main #4371 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 176 176
Lines 10377 10377
=======================================
Hits 9176 9176
Misses 971 971
Partials 230 230 Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Nov 10, 2021
| @@ -214,3 +210,4 @@ spec: | |||
| # path: cert.pem | |||
| # - key: key.pem | |||
| # path: key.pem | |||
|
|
|||
There was a problem hiding this comment.
Remove this extra new line, already one new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The k8s example here has old otel collector image which does not had the new tls config implementation so replacing with new one and command line flag --mem-ballast-size-mib has been deprecated so removed that flag as well.
Link to tracking Issue:
4247
Testing:
I performed following steps in minikube k8s
$ kubectl apply -f otel-config.yaml
$ kubectl get pod
and checked all pod were up and there were no TLS error
Documentation:
Once it gets merged I will update the docs.
Since Easycla is not being triggered for my account which is https://github.com/shree007 so I am trying with another account. I have created the Linux foundation account and connect the my current github account.