-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update Kubernetes example to latest version #4278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4278 +/- ##
==========================================
- Coverage 88.45% 87.32% -1.13%
==========================================
Files 173 182 +9
Lines 10443 10763 +320
==========================================
+ Hits 9237 9399 +162
- Misses 969 1120 +151
- Partials 237 244 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would appreciate if you could add back the newline at the end of the file, but I won't block the PR because of that.
Tested with:
$ kubectl apply -f https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector/8cd325532076056d428dea6b9d61e0622b82d637/examples/k8s/otel-config.yaml
configmap/otel-agent-conf created
daemonset.apps/otel-agent created
configmap/otel-collector-conf created
service/otel-collector created
deployment.apps/otel-collector created
$ kubectl get pods
NAME READY STATUS RESTARTS AGE
otel-agent-l9847 1/1 Running 0 13s
otel-collector-7484768d74-h5rkl 1/1 Running 0 13s
/easycla |
1 similar comment
/easycla |
@shree007 Can you please squash all commits into one to re-trigger easycla? |
@bogdandrutu ok, i will do. |
ee4b7a1
to
7b94e5e
Compare
This PR fixes the "Play the OTel Challenge" link - https://pipestorm.splunk.com/ |
|
/easycla |
@shree007 do you have the easy CLA signed? |
@shree007 please confirm you went through the EasyCLA steps. In any case, I asked on #easycla at CNCF Slack, as it's not clear at all why it hasn't been triggered. |
/easycla |
1 similar comment
/easycla |
@jpkrohling @bogdandrutu I followed this one https://docs.linuxfoundation.org/lfx/easycla/v1-deprecated/contributors/individual-contributor |
Closing and opening the PR to see if EasyCLA gets triggered. |
Superseeded by #4329 |
Description:
The k8s example here has old otel collector image which does not had the new tls config implementation so replacing with new one and command line flag --mem-ballast-size-mib has been deprecated so removed that flag as well.
Link to tracking Issue:
4247
Testing:
I performed following steps in minikube k8s
$ kubectl apply -f otel-config.yaml
$ kubectl get pod
and checked all pod were up and there were no TLS error
Documentation:
Once it gets merged I will update the docs.