Skip to content

Update Kubernetes example to latest version #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shree007
Copy link
Contributor

Description:
The k8s example here has old otel collector image which does not had the new tls config implementation so replacing with new one and command line flag --mem-ballast-size-mib has been deprecated so removed that flag as well.

Link to tracking Issue:
4247

Testing:
I performed following steps in minikube k8s
$ kubectl apply -f otel-config.yaml
$ kubectl get pod

and checked all pod were up and there were no TLS error

Documentation:
Once it gets merged I will update the docs.

@shree007 shree007 requested review from a team and bogdandrutu October 27, 2021 19:25
@shree007 shree007 changed the title Fix k8s example config Remove Command Line flag mem-ballast-size-mib and replacing the otel/opentelemetry-collector-dev:latest with otel/opentelemetry-collector:0.37.1 Oct 27, 2021
@jpkrohling jpkrohling changed the title Remove Command Line flag mem-ballast-size-mib and replacing the otel/opentelemetry-collector-dev:latest with otel/opentelemetry-collector:0.37.1 Update Kubernetes example to latest version Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #4278 (71ab16d) into main (5abd73a) will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4278      +/-   ##
==========================================
- Coverage   88.45%   87.32%   -1.13%     
==========================================
  Files         173      182       +9     
  Lines       10443    10763     +320     
==========================================
+ Hits         9237     9399     +162     
- Misses        969     1120     +151     
- Partials      237      244       +7     
Impacted Files Coverage Δ
config/configunmarshaler/defaultunmarshaler.go 100.00% <0.00%> (ø)
cmd/builder/internal/builder/main.go 0.00% <0.00%> (ø)
config/configmapprovider/file.go 100.00% <0.00%> (ø)
config/configmapprovider/merge.go 84.21% <0.00%> (ø)
config/configmapprovider/simple.go 100.00% <0.00%> (ø)
config/configmapprovider/properties.go 89.65% <0.00%> (ø)
cmd/builder/internal/builder/config.go 45.71% <0.00%> (ø)
config/configmapprovider/expand.go 76.00% <0.00%> (ø)
config/configmapprovider/default.go 100.00% <0.00%> (ø)
config/configmapprovider/inmemory.go 70.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abd73a...71ab16d. Read the comment docs.

@jpkrohling jpkrohling self-requested a review October 28, 2021 07:55
@jpkrohling jpkrohling self-assigned this Oct 28, 2021
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would appreciate if you could add back the newline at the end of the file, but I won't block the PR because of that.

Tested with:

$ kubectl apply -f https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector/8cd325532076056d428dea6b9d61e0622b82d637/examples/k8s/otel-config.yaml
configmap/otel-agent-conf created
daemonset.apps/otel-agent created
configmap/otel-collector-conf created
service/otel-collector created
deployment.apps/otel-collector created

$ kubectl get pods 
NAME                              READY   STATUS    RESTARTS   AGE
otel-agent-l9847                  1/1     Running   0          13s
otel-collector-7484768d74-h5rkl   1/1     Running   0          13s

@bogdandrutu
Copy link
Member

/easycla

1 similar comment
@bogdandrutu
Copy link
Member

/easycla

@bogdandrutu
Copy link
Member

@shree007 Can you please squash all commits into one to re-trigger easycla?

@shree007
Copy link
Contributor Author

shree007 commented Oct 28, 2021

@shree007 Can you please squash all commits into one to re-trigger easycla?

@bogdandrutu ok, i will do.

@shree007 shree007 force-pushed the fix-k8s-example-config branch from ee4b7a1 to 7b94e5e Compare October 28, 2021 18:48
@eddiesimeon
Copy link

This PR fixes the "Play the OTel Challenge" link - https://pipestorm.splunk.com/

@shree007
Copy link
Contributor Author

@shree007 Can you please squash all commits into one to re-trigger easycla?
@bogdandrutu
I have squashed in one commit.

@bogdandrutu
Copy link
Member

/easycla

@bogdandrutu
Copy link
Member

@shree007 do you have the easy CLA signed?

@jpkrohling
Copy link
Member

@shree007 please confirm you went through the EasyCLA steps. In any case, I asked on #easycla at CNCF Slack, as it's not clear at all why it hasn't been triggered.

@shree007
Copy link
Contributor Author

/easycla

1 similar comment
@bogdandrutu
Copy link
Member

/easycla

@shree007
Copy link
Contributor Author

@jpkrohling @bogdandrutu
I have created one account in the linux foundation and its connected with my respective github account.
But On my PR the Easycla link is not being enabled so i am unable to sign off for now.

I followed this one https://docs.linuxfoundation.org/lfx/easycla/v1-deprecated/contributors/individual-contributor
I am keeping an eye on #easycla channel as i saw your post there.
I am waiting the reply there.
i will do further things based on the provided info there.
Thanks

@jpkrohling jpkrohling closed this Nov 1, 2021
@jpkrohling jpkrohling reopened this Nov 1, 2021
@jpkrohling
Copy link
Member

Closing and opening the PR to see if EasyCLA gets triggered.

@codeboten
Copy link
Contributor

Superseeded by #4329

@codeboten codeboten closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants