-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[component][componenttest] Add validation for config serialization #12912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[component][componenttest] Add validation for config serialization #12912
Conversation
b11c31d
to
e08944e
Compare
Could you add tests? (and fix the failing CI checks) |
I don't think this change requires changelog. |
I think it does require a changelog entry. This changes the behavior of a public method in a public package. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12912 +/- ##
==========================================
+ Coverage 91.66% 91.69% +0.02%
==========================================
Files 499 499
Lines 27425 27449 +24
==========================================
+ Hits 25140 25168 +28
+ Misses 1806 1803 -3
+ Partials 479 478 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
83914a3
to
d299e9b
Compare
- run go mod tidy
- fix crosslink ci - fix unit test coverage
d299e9b
to
7efced9
Compare
I have completed all the changes from my end, and the implementation is now ready for review. It should pass all CI checks successfully. Thank you for your patience. |
7286ad6
to
51c85aa
Compare
Please let me know if there's anything I might have missed in this PR or anything I can do to help expedite the review process. |
c775b48
to
596a7d3
Compare
Description
This unit test enhancement ensures that the configuration can be serialized correctly.
Link to tracking issue
Fixes #12906