Fix 'otelcol.component.kind' value capitalization #12865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
fix-attribute-cap
branch
from
378e099 to
26036d3
Compare
djaglowski
force-pushed
the
fix-attribute-cap
branch
from
26036d3 to
a9e6e21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12865 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 493 493
Lines 26984 26984
=======================================
Hits 24682 24682
Misses 1818 1818
Partials 484 484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
approved these changes
Apr 15, 2025
songy23
approved these changes
Apr 15, 2025
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
May 8, 2025
These logger fields are added by the OTel collector. - otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865 - otelcol.signal and not signals While at it, use the newer All iterator function for logs.
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
May 8, 2025
These logger fields are added by the OTel collector. - otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865 - otelcol.signal and not signals See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers. While at it, use the newer All iterator function for logs.
6 tasks
mauri870
added a commit
to elastic/beats
that referenced
this pull request
May 9, 2025
These logger fields are added by the OTel collector. - otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865 - otelcol.signal and not signals See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers. While at it, use the newer All iterator function for logs.
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
May 9, 2025
These logger fields are added by the OTel collector. - otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865 - otelcol.signal and not signals See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers. While at it, use the newer All iterator function for logs. (cherry picked from commit f6db7a6)
Open
6 tasks
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
May 9, 2025
These logger fields are added by the OTel collector. - otelcol.component.kind should be lowercase. See open-telemetry/opentelemetry-collector#12865 - otelcol.signal and not signals See the proposal at https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers. While at it, use the newer All iterator function for logs. (cherry picked from commit f6db7a6)
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings capitalization in line with the attributes defined in the Pipeline Component Telemetry RFC.