Skip to content

[mdatagen] Add supportsSignal func #12640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

sincejune
Copy link
Contributor

Description

This PR added supportsSignal func to Metadata type to reduce duplicated code blocks for checking supported signals.

Link to tracking issue

n/a

Testing

Already covered

Documentation

Added

@sincejune sincejune requested review from dmitryax and a team as code owners March 16, 2025 06:49
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (0e9e259) to head (1aed010).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12640      +/-   ##
==========================================
- Coverage   91.66%   91.64%   -0.02%     
==========================================
  Files         478      478              
  Lines       26456    26391      -65     
==========================================
- Hits        24250    24187      -63     
+ Misses       1747     1745       -2     
  Partials      459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 16, 2025
Merged via the queue into open-telemetry:main with commit 6d82b55 Mar 16, 2025
55 checks passed
@sincejune sincejune deleted the add-supports-signal-func branch March 18, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants