[confmap] Maintain nil slice values when marshaling and unmarshaling #11882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11882 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 469 469
Lines 25394 25394
=======================================
Hits 23409 23409
Misses 1574 1574
Partials 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
evan-bradley
changed the title
mx-psi
approved these changes
Mar 11, 2025
yurishkuro
approved these changes
Mar 11, 2025
evan-bradley
changed the title
evan-bradley
added a commit
to evan-bradley/opentelemetry-collector
that referenced
this pull request
Mar 18, 2025
…shaling (open-telemetry#11882)" This reverts commit b8830dd.
evan-bradley
added a commit
to evan-bradley/opentelemetry-collector
that referenced
this pull request
Mar 18, 2025
…shaling (open-telemetry#11882)" This reverts commit b8830dd.
evan-bradley
added a commit
to evan-bradley/opentelemetry-collector
that referenced
this pull request
Mar 18, 2025
…shaling (open-telemetry#11882)" This reverts commit b8830dd.
codeboten
pushed a commit
that referenced
this pull request
Mar 18, 2025
#### Description #11882 introduced issues with handling slices which have default values. It's likely that the removal of `zeroSliceHookFunc` is causing problems with overriding default lists.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Adds a test for #12661 and another test present on #11882. I verified that the first test fails in v0.123.0: on this version the slice has `[]S{A: "A", B: "B"}` instead.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> A second attempt at #11882. Note that I added some tests in #12871 to prevent something like #12661 from happening again. #### Link to tracking issue Fixes #11749 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> See tests from #12871 as well as the new tests added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on #11755 to show how we could test for a 1:1 mapping between map[string]any <->
confmap.Conf<-> Config structs for[]any(nil)and[]any{}slices.