Skip to content

Implement Optional type #12981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mx-psi opened this issue May 7, 2025 · 2 comments
Open

Implement Optional type #12981

mx-psi opened this issue May 7, 2025 · 2 comments
Assignees
@mx-psi
Labels
area:config

Comments

@mx-psi
Copy link
Member

mx-psi commented May 7, 2025

Component(s)

confmap

Describe the issue you're reporting

On #12596 we argued for defining an Optional type to be used in configuration. We now need to implement it!
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi mx-psi mentioned this issue May 8, 2025
Open
@mx-psi
Copy link
Member Author

mx-psi commented May 8, 2025

#12996 (comment) is a first hurdle. We can work around it by either fixing this upstream or rewriting the existing hooks in terms of reflect.Values.

@mx-psi mx-psi mentioned this issue May 8, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 9, 2025
@mx-psi
[chore] Add tests loading nil to any (#12998)
6bd77b3 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

While working on #12981, I would have found it useful to have these
tests, since they surfaced a bug when enabling `DecodeNil`.
@mx-psi mx-psi moved this from Todo to In Progress in Collector: v1 May 9, 2025
@mx-psi mx-psi self-assigned this May 9, 2025
@mx-psi mx-psi mentioned this issue May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mx-psi mx-psi

Labels
area:config
Projects
Collector: v1
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mx-psi