Add jmxmetrics 1.6 to integration test #5374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsuereth Any tips on what could cause the mysterious testcontainers panic? |
|
@anuraaga I've seen this before, but I've never investigated :) |
bogdandrutu
approved these changes
Sep 22, 2021
| @@ -43,6 +43,7 @@ import ( | |||
| var jmxJarReleases = map[string]string{ | |||
| "1.0.0-alpha": "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-java-contrib-jmx-metrics/1.0.0-alpha/opentelemetry-java-contrib-jmx-metrics-1.0.0-alpha.jar", | |||
| "1.4.0-alpha": "https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-metrics/1.4.0-alpha/opentelemetry-jmx-metrics-1.4.0-alpha.jar", | |||
| "1.6.0-alpha": "https://github.com/open-telemetry/opentelemetry-java-contrib/releases/download/v1.6.0/opentelemetry-jmx-metrics.jar", | |||
There was a problem hiding this comment.
The tested script isn't compatible w/ this release since it still uses labels: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.36.0/receiver/jmxreceiver/testdata/script.groovy#L17
There was a problem hiding this comment.
@anuraaga I took a crack at updating this: https://gist.github.com/rmfitzpatrick/696bb9a8b236db0165b2359c898a70bb
There was a problem hiding this comment.
Thanks a lot! Do you mind if I close this PR and let you make it given you're the expert? :-)
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
* [docs] add status information for OTLP exporter Adds the status header for the OTLP exporter. * add stability per signal * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds recently released 1.6 of jmx-metrics to integration tests for the receiver
Link to tracking Issue:
Testing:
Documentation: