Skip to content

[receiver/sqlserver] Add metric for wait times #39990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[receiver/sqlserver] Add metric for wait times #39990

wants to merge 2 commits into from

Conversation

crobert-1
Copy link
Member

Description

This metric, sqlserver.os.wait.duration tracks the total wait time of each type on a given database. A new query is required, using telegraf's existing query.

Feedback on metric name is welcome.

Link to tracking issue

Part of #39977

Testing

Updated and added new tests. This needed more testing than #39985 as a new query is being added.

@crobert-1 crobert-1 requested a review from a team as a code owner May 9, 2025 22:30
@crobert-1 crobert-1 requested a review from djaglowski May 9, 2025 22:30
@github-actions github-actions bot added receiver/sqlserver Run Windows Enable running windows test on a PR labels May 9, 2025
@github-actions github-actions bot requested review from sincejune and StefanKurek May 9, 2025 22:30
@crobert-1
cleanup
9270f6c 
- Add note about metric only available on direct connection
- Use constants when possible
- Clarify test names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@sincejune sincejune Awaiting requested review from sincejune

@StefanKurek StefanKurek Awaiting requested review from StefanKurek

At least 1 approving review is required to merge this pull request.

Assignees

@atoulme atoulme

Labels
receiver/sqlserver Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crobert-1 @atoulme