[receiver/apachespark] Skip SKIPPED status #39955
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
May 9, 2025
| @@ -262,6 +262,8 @@ func (s *sparkScraper) recordStages(stageStats []models.Stage, now pcommon.Times | |||
| s.mb.RecordSparkStageStatusDataPoint(now, 0, false, false, true, false) | |||
| case "FAILED": | |||
| s.mb.RecordSparkStageStatusDataPoint(now, 0, false, false, false, true) | |||
| case "SKIPPED": | |||
| continue | |||
There was a problem hiding this comment.
The problem is that SKIPPED is not a real record.
It means that this was already done.
So adding it as a record actually misleading.
There was a problem hiding this comment.
Thank you for your clarification.
|
@mrsillydog @Caleb-Hurshman please review as codeowners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not log warning on SKIPPED status.
SKIPPED is a known Spark status.
Testing
Manually tested.
Documentation
Not needed.