Export the configkafka package #39946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
commented
May 8, 2025
| status: | ||
| disable_codecov_badge: true | ||
| codeowners: | ||
| active: [pavolloffay, MovieStoreGuy, axw] |
There was a problem hiding this comment.
Hi @pavolloffay, @MovieStoreGuy, @axw, I hope you would be ok with being code owners of this moved package? I listed you in this file because you are also listed in the internal package.
There was a problem hiding this comment.
Linking to the PR that introduced the internal package. I don't see any reasons stated in its introduction why it would need to be internal.
4 tasks
|
@ptodev please address the CI failures and the conflicts and mark the PR ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of the configuration arguments for Kafka exporters and receivers and in the internal
configkafkapackage. This prevents tools outside of the Collector repo from using them.