[chore][postgresqlreceiver] do not report record if the total exec time is not changed #39942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
approved these changes
May 8, 2025
sincejune
approved these changes
May 8, 2025
sincejune
reviewed
May 8, 2025
| @@ -305,6 +305,9 @@ func (p *postgreSQLScraper) collectTopQuery(ctx context.Context, dbClient client | |||
| row[dbAttributePrefix+columnName] = finalValue | |||
| } | |||
| } | |||
| if row[dbAttributePrefix+totalExecTimeColumnName] == 0.0 { | |||
There was a problem hiding this comment.
Is it any possible that the value response 0 instead of 0.0?
There was a problem hiding this comment.
nope, it wont convert to int.
although it is not clear from this line, but we can tell from https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/39942/files#diff-92b155f73edce85fb5d2b214b668ea8ec9dd01eed47428e129fde9cd29a1ae22L260
it is a little bit unclear. i will see if i can improve on this (in a follow up pr)
cuichenli
changed the title
|
@antonblock please review as codeowner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the current implementation would report queries not executed between the last elapsed time. which is not ideal. it would flush the downstream. this change will avoid the issue.
Testing
Documentation