[receiver/apachespark] Add application id filter #39936
Open
+95
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog. Please clarify in the README that the filters are a union, meaning all application names and IDs matching will be allowed. Since we already have application names, why add ids? |
|
Please fix CI and address feedback, and move back to ready for review when done. |
|
Sure. Feature I need: The start - end should be also span. But this is next change. |
NN---
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add application ids filter.
Link to tracking issue
Fixes #39627
Testing
Run with application ids specified.
Documentation
Allow filtering Apache Spark receiver by application id in addition to application name.