[processor/transform] Fix context inferrer so it takes into consideration global conditions #39463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
changed the title
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
edmocosta
changed the title
TylerHelmuth
pushed a commit
that referenced
this pull request
Apr 17, 2025
…ntext inferrer conditions (#39465) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added a new option `ottl.WithContextInferenceConditions` to the `ParserCollection.ParseStataments` so API users can provide extra context inferrer's conditions and have theirs hints considered by the default context inferrer. Follow up: #39463 (includes this PR changes) <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to #39455 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests
edmocosta
force-pushed
the
fix-global-conditions-ctx-inference
branch
from
855b246 to
67dbede
Compare
TylerHelmuth
approved these changes
Apr 22, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…ntext inferrer conditions (open-telemetry#39465) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added a new option `ottl.WithContextInferenceConditions` to the `ParserCollection.ParseStataments` so API users can provide extra context inferrer's conditions and have theirs hints considered by the default context inferrer. Follow up: open-telemetry#39463 (includes this PR changes) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to open-telemetry#39455 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…ntext inferrer conditions (open-telemetry#39465) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Added a new option `ottl.WithContextInferenceConditions` to the `ParserCollection.ParseStataments` so API users can provide extra context inferrer's conditions and have theirs hints considered by the default context inferrer. Follow up: open-telemetry#39463 (includes this PR changes) <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to open-telemetry#39455 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the context inferrer to also take into consideration the global OTTL
conditionsconfiguration.For that, it uses the new option
ottl.WithContextInferenceConditionsrecently added to theParserCollection.ParseStataments(#39465).Link to tracking issue
Fixes #39455
Testing
Unit tests