fix: make ACLs optional for AWS S3 buckets #39354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mildly related, I'm unsure if the recently added storage class should have a static default or if that should also be optional. |
|
This fixes the default parameter on the ACL field, I misread the docs when I added it initially |
atoulme
approved these changes
Apr 14, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes a problem where ACLs have become required on configuration of the AWS S3 exporter. AWS explicitly recommends to disable ACLs on buckets https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39346 <!--Describe what testing was performed and which tests were added.--> #### Testing Added test to ensure configuration of the exporter worked as expected when ACL values were set. Updated existing config tests to ensure no ACL is set by default. <!--Describe the documentation added.--> #### Documentation Updated README.md to show ACLs are optional and off by default. Additionally added myself as a codeowner as I'm willing to take on partial ownership here. <!--Please delete paragraphs that you did not use before submitting.-->
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes a problem where ACLs have become required on configuration of the AWS S3 exporter. AWS explicitly recommends to disable ACLs on buckets https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#39346 <!--Describe what testing was performed and which tests were added.--> #### Testing Added test to ensure configuration of the exporter worked as expected when ACL values were set. Updated existing config tests to ensure no ACL is set by default. <!--Describe the documentation added.--> #### Documentation Updated README.md to show ACLs are optional and off by default. Additionally added myself as a codeowner as I'm willing to take on partial ownership here. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a problem where ACLs have become required on configuration of the AWS S3 exporter.
AWS explicitly recommends to disable ACLs on buckets https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html
Link to tracking issue
Fixes #39346
Testing
Added test to ensure configuration of the exporter worked as expected when ACL values were set.
Updated existing config tests to ensure no ACL is set by default.
Documentation
Updated README.md to show ACLs are optional and off by default.
Additionally added myself as a codeowner as I'm willing to take on partial ownership here.