Skip to content

[connector/spanmetricsconnector] Initialise new calls_total metrics at 0 #39052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

Frapschen
Copy link
Contributor

Description

fix: #38537

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Frapschen Frapschen changed the title Initialise new calls_total metrics at 0 [connector/spanmetricsconnector] Initialise new calls_total metrics at 0 Apr 8, 2025
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Written by code owner, one review. LGTM.

@atoulme atoulme merged commit bddc307 into open-telemetry:main Apr 8, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 8, 2025
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2025
…t 0 (open-telemetry#39052)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
fix:
open-telemetry#38537

Signed-off-by: Murphy Chen <[email protected]>
@Frapschen Frapschen deleted the fix-spanmetrics-38537 branch April 9, 2025 02:57
LucianoGiannotti pushed a commit to LucianoGiannotti/opentelemetry-collector-contrib that referenced this pull request Apr 9, 2025
…t 0 (open-telemetry#39052)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
fix:
open-telemetry#38537

Signed-off-by: Murphy Chen <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
…t 0 (open-telemetry#39052)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
fix:
open-telemetry#38537

Signed-off-by: Murphy Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span Metrics Connector should initialise stale counter series at 0
4 participants