[spanmetricsconnector] Add instrumentation scope #38001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
changed the title
atoulme
reviewed
Feb 20, 2025
atoulme
reviewed
Feb 20, 2025
atoulme
reviewed
Feb 20, 2025
atoulme
reviewed
Feb 20, 2025
|
cc @portertech @Frapschen can you take a look? |
Frapschen
reviewed
Mar 18, 2025
Frapschen
reviewed
Mar 18, 2025
Frapschen
reviewed
Mar 18, 2025
|
@Frapschen @portertech please review as codeowners. |
This was referenced Mar 23, 2025
Frapschen
reviewed
Mar 24, 2025
…anmetricsconnector Signed-off-by: Israel Blancas <[email protected]>
|
@open-telemetry/android-maintainers this was approved by the code owner. Could we merge it? |
atoulme
approved these changes
Mar 27, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description Added the instrumentation scope to the metrics generated by the span metrics connector. #### Link to tracking issue Fixes open-telemetry#23662 #### Testing Added a new unit test to cover this feature. #### Documentation Some notes to the `README.md` file explaining the new config files. Signed-off-by: Israel Blancas <[email protected]>
songy23
pushed a commit
that referenced
this pull request
Apr 24, 2025
I would like to become a code owner of spanmetrics connector. I have been using it in my current and previous companies. Also, I contributed some times to this component: #39084 #38945 #38001 #34485 Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the instrumentation scope to the metrics generated by the span metrics connector.
Link to tracking issue
Fixes #23662
Testing
Added a new unit test to cover this feature.
Documentation
Some notes to the
README.mdfile explaining the new config files.