envoyalsreceiver: add identifier #37800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
envoyals-part2
branch
from
3639154 to
aa29b45
Compare
evan-bradley
approved these changes
Feb 24, 2025
Comment on lines
+21
to
+22
| nodeAttr = "node" | ||
| logNameAttr = "log_name" |
There was a problem hiding this comment.
Not immediately important since there are no semantic conventions around these, but we should consider making these attributes feel more OTel-native in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow up: #37193, this receiver is still under development, no additional release notes required
Link to tracking issue
Fixes
Testing
Documentation