[tailsamplingprocessor] Fix the decision timer metric to measure > 50ms #37722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er latencies beyond 50ms. Previously the decision timer metric was in microseconds. Because the max histogram bucket was 50000, it capped the maximum measurable latency at 50ms. This commit changes the metric to be in milliseconds, which allows for measuring latencies of up to 50 seconds. Since the default decision tick is 1s, it's necessary to observe when the latency is approaching 1s. I'm not sure how big of a breaking change it is to update the unit, but given the previous value was not super useful, I thought it was better to change it.
|
I've added |
portertech
reviewed
Feb 7, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: bug_fix |
There was a problem hiding this comment.
On the fence, do we consider this breaking?
There was a problem hiding this comment.
After thinking more, it does feel like a breaking change. Updated.
portertech
approved these changes
Feb 7, 2025
jpkrohling
approved these changes
Feb 8, 2025
crobert-1
approved these changes
Feb 10, 2025
|
Once the merge conflict is resolved, this is ready to go. |
|
@jpkrohling Thanks, I think it's good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the decision timer metric was in microseconds. Because the max histogram bucket was 50000, it capped the maximum measurable latency at 50ms. This commit changes the metric to be in milliseconds, which allows for measuring latencies of up to 50 seconds.
Since the default decision tick is 1s, it's necessary to observe when the latency is approaching 1s.
I'm not sure how big of a breaking change it is to update the unit, but given the previous value was not super useful, I thought it was better to change it.
Here's an example of the current state:
Notice how the average latency is running much higher than the p99, indicating that we are missing important data on how slow the decision tick actually is.