Skip to content

[receiver/splunkenterprise] 36330 add build info as attribute #37508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 10, 2025

Conversation

shalper2
Copy link
Contributor

Description

Adds a new attribute which optionally includes build and/or version info for the Splunk host being monitored. Also removed the use of context module in the client calls used by the scrape functions.

Link to tracking issue

Fixes 36330

Testing

unit tests updated and passing

Documentation

README.md was updated to include new configuration field

@shalper2 shalper2 force-pushed the 36330-bi-as-attrs branch 2 times, most recently from a87853f to 52203aa Compare February 11, 2025 15:40
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 26, 2025
@atoulme
Copy link
Contributor

atoulme commented Mar 4, 2025

Please resolve conflicts

@github-actions github-actions bot removed the Stale label Mar 5, 2025
@atoulme atoulme marked this pull request as draft March 17, 2025 22:50
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@shalper2 shalper2 force-pushed the 36330-bi-as-attrs branch from 0910645 to f3492b4 Compare April 8, 2025 17:16
@shalper2 shalper2 changed the title 36330 bi as attrs [receiver/splunkenterprise] 36330 add build info as attribute Apr 8, 2025
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what you really want, I'm OK with it. Still think you'd want these attributes as resource attributes.

@atoulme atoulme merged commit 6f8b3ce into open-telemetry:main Apr 10, 2025
172 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 10, 2025
akshays-19 pushed a commit to akshays-19/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2025
…elemetry#37508)

#### Description
Adds a new attribute which optionally includes build and/or version info
for the Splunk host being monitored. Also removed the use of `context`
module in the client calls used by the scrape functions.

#### Link to tracking issue
Fixes
[36330](open-telemetry#36330)

#### Testing
unit tests updated and passing

#### Documentation
README.md was updated to include new configuration field
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
…elemetry#37508)

#### Description
Adds a new attribute which optionally includes build and/or version info
for the Splunk host being monitored. Also removed the use of `context`
module in the client calls used by the scrape functions.

#### Link to tracking issue
Fixes
[36330](open-telemetry#36330)

#### Testing
unit tests updated and passing

#### Documentation
README.md was updated to include new configuration field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/splunkenterprise] Add Attributes to track Build & Version Data
4 participants