-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[receiver/splunkenterprise] 36330 add build info as attribute #37508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eaf8c05
to
7293a9a
Compare
1ec48fd
to
9b45c45
Compare
a87853f
to
52203aa
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Please resolve conflicts |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
52203aa
to
10e0807
Compare
0910645
to
f3492b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is what you really want, I'm OK with it. Still think you'd want these attributes as resource attributes.
…elemetry#37508) #### Description Adds a new attribute which optionally includes build and/or version info for the Splunk host being monitored. Also removed the use of `context` module in the client calls used by the scrape functions. #### Link to tracking issue Fixes [36330](open-telemetry#36330) #### Testing unit tests updated and passing #### Documentation README.md was updated to include new configuration field
…elemetry#37508) #### Description Adds a new attribute which optionally includes build and/or version info for the Splunk host being monitored. Also removed the use of `context` module in the client calls used by the scrape functions. #### Link to tracking issue Fixes [36330](open-telemetry#36330) #### Testing unit tests updated and passing #### Documentation README.md was updated to include new configuration field
Description
Adds a new attribute which optionally includes build and/or version info for the Splunk host being monitored. Also removed the use of
context
module in the client calls used by the scrape functions.Link to tracking issue
Fixes 36330
Testing
unit tests updated and passing
Documentation
README.md was updated to include new configuration field