Splunkenterprisereceiver add health metric (#36695) #36695
Conversation
* Initial commit * Corrected structs to fit json API response * Added to changelog * PR number added to changelog
|
Build fails with
|
macolby42
changed the title
| | Name | Description | Values | | ||
| | ---- | ----------- | ------ | | ||
| | splunk.feature | The Feature name from the Splunk Health Introspection Endpoint | Any Str | | ||
| | splunk.feature.health | The Health (in color form) of a Splunk Feature from the Splunk Health Introspection Endpoint | Any Str | |
There was a problem hiding this comment.
sure you need that? you already get the status via the value right?
There was a problem hiding this comment.
The value only indicates whether it is red or not. A value of 1 could be green or yellow. It's not ideal, but color system for splunkd what implemented long before our use of OTel.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| return | ||
| } | ||
|
|
||
| ctx = context.WithValue(ctx, endpointType("type"), typeCm) |
There was a problem hiding this comment.
Do you mind expanding on why there is values being stored inside the context here?
There was a problem hiding this comment.
This context value (which is defined in each scrape) is used to route the request to the correct api endpoint
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@shalper2 and @greatestusername please review |
|
Looks great, thanks! |
MovieStoreGuy
added
ready to merge
…en-telemetry#36695) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds `splunk.health` metric that uses the introspection endpoint at `/services/server/health/splunkd/details`. The metric features 2 attributes: `splunk.feature`: Describes the part of the server's feature `splunk.feature.health`: Describes (in red, yellow, green) the health status of the given feature The metric will remain a value of 1 unless the feature's health becomes 'red.' <!--Describe what testing was performed and which tests were added.--> #### Testing Built a custom version of splunk-otel-collector that referenced this code. Then ran it on a Splunk stack, and received metrics out. Also created generated tests. <!--Describe the documentation added.--> #### Documentation Added an entry to `documentation.md` describing the new metric. --------- Co-authored-by: Sean Marciniak <[email protected]>
Description
Adds
splunk.healthmetric that uses the introspection endpoint at/services/server/health/splunkd/details. The metric features 2 attributes:splunk.feature: Describes the part of the server's featuresplunk.feature.health: Describes (in red, yellow, green) the health status of the given featureThe metric will remain a value of 1 unless the feature's health becomes 'red.'
Testing
Built a custom version of splunk-otel-collector that referenced this code. Then ran it on a Splunk stack, and received metrics out. Also created generated tests.
Documentation
Added an entry to
documentation.mddescribing the new metric.