Skip to content

[extension/headerssetter] mask the default_value field to hide possible sensitive info #39127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dloucasfx opened this issue Apr 2, 2025 · 1 comment · Fixed by #39144
Closed

[extension/headerssetter] mask the default_value field to hide possible sensitive info #39127

dloucasfx opened this issue Apr 2, 2025 · 1 comment · Fixed by #39144
Assignees
@dloucasfx
Labels
extension/headerssetter

Comments

@dloucasfx
Copy link
Contributor

dloucasfx commented Apr 2, 2025 •
edited
Loading

Component(s)

extension/headerssetter

Describe the issue you're reporting

The default_value can hold sensitive values, especially if we are using it to set tokens.
Suggesting to use configopaque.String instead of string for default_value

Pushing a PR shortly
@dloucasfx dloucasfx added the needs triage New item requiring triage label Apr 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@VihasMakwana VihasMakwana removed the needs triage New item requiring triage label Apr 3, 2025
@dloucasfx dloucasfx mentioned this issue Apr 3, 2025
Merged
@atoulme atoulme closed this as completed in 7d47e9c Apr 7, 2025
@github-actions github-actions bot mentioned this issue Apr 8, 2025
Closed
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this issue Apr 8, 2025
@dloucasfx @atoulme @dmathieu
[extension/headerssetter] Change DefaultValue to use `configopaque.…
c795fa6 
…String` type (open-telemetry#39144)

#### Description
Change `DefaultValue` to `opaque.String`  type

#### Link to tracking issue
Fixes
open-telemetry#39127

Signed-off-by: Dani Louca <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
LucianoGiannotti pushed a commit to LucianoGiannotti/opentelemetry-collector-contrib that referenced this issue Apr 9, 2025
@dloucasfx @atoulme @LucianoGiannotti
[extension/headerssetter] Change DefaultValue to use `configopaque.…
04fd3a2 
…String` type (open-telemetry#39144)

#### Description
Change `DefaultValue` to `opaque.String`  type

#### Link to tracking issue
Fixes
open-telemetry#39127

Signed-off-by: Dani Louca <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this issue Apr 24, 2025
@dloucasfx @atoulme @Fiery-Fenix
[extension/headerssetter] Change DefaultValue to use `configopaque.…
acdfb47 
…String` type (open-telemetry#39144)

#### Description
Change `DefaultValue` to `opaque.String`  type

#### Link to tracking issue
Fixes
open-telemetry#39127

Signed-off-by: Dani Louca <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dloucasfx dloucasfx

Labels
extension/headerssetter
Projects
None yet
Milestone
No milestone
2 participants
@dloucasfx @VihasMakwana