You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, if we want to receive attributes from cloudflare logpush. We need to specify the attributes manually in the config file. Cloudflare logpush already gives us the option to specify which attributes are sent. Therefore, it's often unnecessary to manually specify (again) which attributes to receive because we simply want to ingest everything that is sent.
I'm proposing a new convention where if the attributes field is empty, then it indicates we want to ingest everything that is sent. This helps users avoid having to modify which fields they want in two places. Happy to submit a PR myself.
receivers:
cloudflare:
logs:
tls:
key_file: some_key_filecert_file: some_cert_fileendpoint: 0.0.0.0:12345secret: 1234567890abcdef1234567890abcdeftimestamp_field: EdgeStartTimestampattributes:
# empty. no attributes specified -> receive all attributes that are sent
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
I'm proposing a new convention where if the attributes field is empty,
then it indicates we want to ingest everything that is sent. This helps
users avoid having to modify which fields they want in two places. Happy
to submit a PR myself. Please check out the linked issue and let me know
if you approve or want any changes. Then I will finish implementing
whatever else is necessary (e.g docs, tests).
<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes#37720
<!--Describe what testing was performed and which tests were added.-->
#### Testing
I added a `TestEmptyAttributes()` test to verify the behavior in
`logs_test.go`
<!--Describe the documentation added.-->
#### Documentation
I documented the new behavior in the `README.md` and added a separate
config example of how it can be used
<!--Please delete paragraphs that you did not use before submitting.-->
Component(s)
receiver/cloudflare
Is your feature request related to a problem? Please describe.
Currently, if we want to receive attributes from cloudflare logpush. We need to specify the attributes manually in the config file. Cloudflare logpush already gives us the option to specify which attributes are sent. Therefore, it's often unnecessary to manually specify (again) which attributes to receive because we simply want to ingest everything that is sent.
^ src
Describe the solution you'd like
I'm proposing a new convention where if the attributes field is empty, then it indicates we want to ingest everything that is sent. This helps users avoid having to modify which fields they want in two places. Happy to submit a PR myself.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: