Skip to content

Add resource attributes to the OpAMP Extension's non-identifying attrs #37487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaronoff97 opened this issue Jan 24, 2025 · 4 comments · Fixed by #38994
Closed

Add resource attributes to the OpAMP Extension's non-identifying attrs #37487

jaronoff97 opened this issue Jan 24, 2025 · 4 comments · Fixed by #38994
Assignees
Labels
enhancement New feature or request extension/opamp

Comments

@jaronoff97
Copy link
Contributor

Component(s)

extension/opamp

Is your feature request related to a problem? Please describe.

I would love to have the resource attrs be available on the OpAMP messages which would help me understand the environment of the agent more effectively.

Describe the solution you'd like

It would be great if we had a way of copying over the resource attributes from the collector into the opamp extensions non-identifying attributes. I think we could do this by default into the non-identifying attrs without issue.

Describe alternatives you've considered

You could duplicate any of the resource attrs manually right now, but you have to do it one by one and explicitly which isn't scalable.

Additional context

No response

@jaronoff97 jaronoff97 added enhancement New feature or request needs triage New item requiring triage labels Jan 24, 2025
@jaronoff97
Copy link
Contributor Author

i can work on this.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 26, 2025
@jaronoff97
Copy link
Contributor Author

oh i can still do this... tbh forgot about it! oops!

@github-actions github-actions bot removed the Stale label Mar 27, 2025
akshays-19 pushed a commit to akshays-19/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
…pen-telemetry#38994)

#### Description
Introduces a new config struct element `IncludeResourceAttributes` which
when enabled (default is false) copies the set resource attributes from
the agent into the non-identifying attributes in the agent description
message.


#### Link to tracking issue
Fixes open-telemetry#37487

#### Testing
Unit


#### Documentation
n/a

---------

Co-authored-by: Evan Bradley <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this issue Apr 24, 2025
…pen-telemetry#38994)

#### Description
Introduces a new config struct element `IncludeResourceAttributes` which
when enabled (default is false) copies the set resource attributes from
the agent into the non-identifying attributes in the agent description
message.


#### Link to tracking issue
Fixes open-telemetry#37487

#### Testing
Unit


#### Documentation
n/a

---------

Co-authored-by: Evan Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension/opamp
Projects
None yet
2 participants