Skip to content

Migrate to AWS v2 SDK #36699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
14 of 19 tasks
MovieStoreGuy opened this issue Dec 6, 2024 · 9 comments
Open
14 of 19 tasks

Migrate to AWS v2 SDK #36699

MovieStoreGuy opened this issue Dec 6, 2024 · 9 comments
Labels
dependency-major-update Indicates a dependency major version bump enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MovieStoreGuy
Copy link
Contributor

MovieStoreGuy commented Dec 6, 2024 •
edited by atoulme
Loading

Component(s)

No response

Describe the issue you're reporting

AWS has annouced that it will be discontinuing support for go AWS SDK v1 and we should be updating the collector to migrate away from it to ensure any issues with the package are dealt with.

https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/

Components using github.com/aws/aws-sdk-go

(generated with rg 'github.com/aws/aws-sdk-go' -l -tgo | cut -d'/' -f1-2 | sort | uniq | sed 's/^/- [ ] /')
@MovieStoreGuy MovieStoreGuy added the needs triage New item requiring triage label Dec 6, 2024
@MovieStoreGuy MovieStoreGuy mentioned this issue Dec 6, 2024
Merged
@MovieStoreGuy MovieStoreGuy added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed needs triage New item requiring triage labels Dec 6, 2024
@MovieStoreGuy
Copy link
Contributor Author

Some of these may already be migrated off, just confirming as we go.

@MovieStoreGuy
Copy link
Contributor Author

For those wanting to pick up this issue,

The migration guides https://aws.github.io/aws-sdk-go-v2/docs/migrating/ is a good starting place to understand what needs to be done.

@github-actions github-actions bot mentioned this issue Dec 10, 2024
Closed
@LZiHaN
Copy link
Member

LZiHaN commented Dec 10, 2024

hi @MovieStoreGuy , is this issue still available? i'd like to working on it, assign please

@mx-psi
Copy link
Member

mx-psi commented Dec 10, 2024

Duplicate of #33208?

@LZiHaN LZiHaN mentioned this issue Dec 12, 2024
Merged
@david-sevcik
Copy link

david-sevcik commented Dec 22, 2024 •
edited
Loading

Hello @MovieStoreGuy and @mx-psi, is it still available? I would like to take it as my first issue

@MovieStoreGuy
Copy link
Contributor Author

Duplicate of #33208?

Yes, sorry

mx-psi pushed a commit that referenced this issue Jan 10, 2025
@LZiHaN
[exporter/datadogexporter] Migrating datadog exporter to use aws sdk …
32dc3be 
…v2 (#36797)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Migrating datadog exporter to use aws sdk v2

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
refer to #36699 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
passes tests.
updated mock client implementations to support the new SDK interfaces.

<!--Describe the documentation added.-->
#### Documentation
no need to update.

<!--Please delete paragraphs that you did not use before submitting.-->
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Jan 13, 2025
@LZiHaN @AkhigbeEromo
[exporter/datadogexporter] Migrating datadog exporter to use aws sdk …
c8bac89 
…v2 (open-telemetry#36797)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Migrating datadog exporter to use aws sdk v2

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
refer to open-telemetry#36699 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
passes tests.
updated mock client implementations to support the new SDK interfaces.

<!--Describe the documentation added.-->
#### Documentation
no need to update.

<!--Please delete paragraphs that you did not use before submitting.-->
@LZiHaN LZiHaN mentioned this issue Jan 18, 2025
Merged
This was referenced Jan 25, 2025
Closed
Closed
Closed
@crobert-1
Copy link
Member

crobert-1 commented Feb 5, 2025 •
edited
Loading

I've checked off the following entries as being complete, all AWS references are v2:

  • confmap/provider
  • exporter/datadog
  • exporter/loadbalancingexporter
  • extension/sigv4authextension
  • internal/metadataproviders
  • receiver/awss3

FWIW, I think some of these may have been false positives, as the original rg script shared included v2 packages.

@crobert-1
Copy link
Member

I've added links to open and merged PRs to the issue description, hopefully it's helpful. Feel free to reformat as necessary.

@crobert-1 crobert-1 marked this as a duplicate of #33208 Feb 5, 2025
@crobert-1
Copy link
Member

I've opened sub-issues for all of the components that don't have an open PR yet. Depending on PR outcomes I can create issues for more components as well.

@crobert-1 crobert-1 added the dependency-major-update Indicates a dependency major version bump label Feb 5, 2025
@Avinash-Acharya Avinash-Acharya mentioned this issue Feb 13, 2025
Closed
This was referenced Feb 17, 2025
Open
Closed
@dehaansa dehaansa mentioned this issue Feb 26, 2025
Closed
atoulme pushed a commit that referenced this issue Mar 6, 2025
@LZiHaN
[receiver/awscloudwatch] Migrating awscloudwatch receiver to use aws …
2d4cb47 
…sdk v2 (#37308)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Migrating awscloudwatch receiver to use aws sdk v2

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

refer to #36699 

<!--Describe what testing was performed and which tests were added.-->
#### Testing

passes tests.

<!--Describe the documentation added.-->
#### Documentation

no need to update.

<!--Please delete paragraphs that you did not use before submitting.-->
This was referenced Mar 9, 2025
Closed
Merged
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
@LZiHaN @zeck-ops
[exporter/datadogexporter] Migrating datadog exporter to use aws sdk …
8d47bcd 
…v2 (open-telemetry#36797)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Migrating datadog exporter to use aws sdk v2

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
refer to open-telemetry#36699 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
passes tests.
updated mock client implementations to support the new SDK interfaces.

<!--Describe the documentation added.-->
#### Documentation
no need to update.

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependency-major-update Indicates a dependency major version bump enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mx-psi @MovieStoreGuy @LZiHaN @david-sevcik @crobert-1