[cmd/opampsupervisor] Add configurable telemetry options for supervisor #35582
Labels
Comments
dpaasman00
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
I'd like to work on this if this is still relevant. CC @evan-bradley |
evan-bradley
added a commit
that referenced
this issue
Mar 4, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds options to configure the telemetry settings for the OpAmp supervisor. This will enable the supervisor, in addition to logging, export metrics and traces as well. For the sake of consistency, I also moved the logger of the supervisor into the telemetrySettings property of the supervisor. This PR does not add any traces or metrics yet, but just provides the groundwork to add those later on. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #35582 <!--Describe what testing was performed and which tests were added.--> #### Testing Added Unit tests. E2E test can be added once we start emitting traces and metrics. --------- Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
cmd/opampsupervisor
Is your feature request related to a problem? Please describe.
Currently monitoring the supervisor consists of capturing debug level logs from stdout. Soon there will be limited configurable logging options (see Additional Context) but there's no support for metrics or tracing or advanced logging options. As it matures, the supervisor should support more monitoring capabilities allowing any emitted telemetry to be captured.
Describe the solution you'd like
Something similar to the collector's
service.telemetryconfiguration options could solve this problem. Granted it is not stable so there's room for change, but consistency between the collector and supervisor would be ideal. Theservice.telemetryconfig can be found here.Describe alternatives you've considered
The supervisor could recognize the
TelemetryConnectionSettingsOpAMP message that is sent to the collector and send it's own telemetry to the specified destinations as well. However this would need more consideration to determine viability, especially since the supervisor currently doesn't forward this message to the collector for configuring collector telemetry.Additional context
I have a PR open at the moment that lays the ground work for adding telemetry configuration starting with logs and the ability to specify log level and output. #35468
The text was updated successfully, but these errors were encountered: