Switch to storing AST nodes on the stack for more accurate method signature check and easy access to parent nodes #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AST nodes have knowledge of their children, but not their parents which is why we use a stack in the
DocstringVisitor. Currently it is used to track a node's unambiguous name (e.g.,my_module.MyClass.__init__). This PR changes that to store the AST nodes themselves, which allows us to use a node's ancestry for more robust logic. For example, with this change, we can distinguish between a function and a method, and more precisely determine whether to ignoreselfandclsparameters in a signature.