Skip to content

Fix SCRIPT1003 error in IE11 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix SCRIPT1003 error in IE11 #7

merged 1 commit into from
Jun 23, 2020

Conversation

kirbyfern
Copy link
Contributor

This PR will fix #6 issue

kirbyfern
kirbyfern commented Jun 23, 2020
View reviewed changes
Copy link
Contributor Author

@kirbyfern kirbyfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since method definitions are not valid in IE11, function names should be...

index.js
@@ -14,14 +14,14 @@
}
},

injectCodeFundContainer() {
injectCodeFundContainer: function() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7

@kirbyfern kirbyfern mentioned this pull request Jun 23, 2020
Closed
@njleonzhang njleonzhang merged commit fe9e86c into njleonzhang:master Jun 23, 2020
@njleonzhang
Copy link
Owner

njleonzhang commented Jun 24, 2020 •
edited
Loading

tnx for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaks IE11 (which is supported by docsify v4)
2 participants
@kirbyfern @njleonzhang