Skip to content

DOC: Deep revision of documentation building #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2019

Conversation

oesteban
Copy link
Contributor

This PR follows up on #3119 (merge that one first for a clean diff, or
diff against oesteban:maint/dedup-apigen-code).

In practice, this PR fixes several broken points of our documentation
(e.g., the workflows list was empty and now it has been updated,
changelog not rendered, API of pure python code not rendered by the
Nipype API parser was missing, etc.).

CHANGES

  • Replaced the numpydoc sphinx extension with
    sphinxcontrib-napoleon.
  • Removed autosummary sphinx extension, required by numpydoc
  • Cleared up docs/sphinxext/*, as nothing is now used from there
  • Use current sphinx-apidoc/autodoc/autosummary
  • Removed the modref generation tooling, as it is not necessary anymore
    after re-enabling apidoc.
  • Cut building warnings down to 321 - just those we incur because our
    API generator. This required some fixes of some docstrings.
    Beyond those corresponding to the Nipype API generator, only missing
    links remain as warnings (for sections in the navbar).
  • Updated changelogs to be reStructuredText.

The ``InterfaceHelpWriter`` class was practically a clone of
``ApiDocWriter``.

Both have been merged into one single module, having the Interface
helper inherit from the ApiDocWriter.
This PR follows up on nipy#3119 (merge that one first for a clean diff, or
diff against ``oesteban:maint/dedup-apigen-code``).

In practice, this PR fixes several broken points of our documentation
(e.g., the workflows list was empty and now it has been updated,
changelog not rendered, API of pure python code not rendered by the
Nipype API parser was missing, etc.).

CHANGES
-------

* Replaced the ``numpydoc`` sphinx extension with
``sphinxcontrib-napoleon``.
* Removed autosummary sphinx extension, required by numpydoc
* Cleared up ``docs/sphinxext/*``, as nothing is now used from there
* Use current sphinx-apidoc/autodoc/autosummary
* Removed the modref generation tooling, as it is not necessary anymore
  after re-enabling apidoc.
* Cut building warnings down to 321 - just those we incur because our
  API generator. This required some fixes of some docstrings.
  Beyond those corresponding to the Nipype API generator, only missing
  links remain as warnings (for sections in the navbar).
* Updated changelogs to be reStructuredText.
@oesteban oesteban force-pushed the maint/refactor-docs-build branch from 4e1bb03 to e24c38a Compare December 21, 2019 01:44
@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #3120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3120   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files         293      293           
  Lines       39222    39222           
  Branches     5168     5168           
=======================================
  Hits        25166    25166           
  Misses      13018    13018           
  Partials     1038     1038
Flag Coverage Δ
#unittests 64.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f56972...ed72503. Read the comment docs.

@oesteban oesteban requested a review from satra December 21, 2019 01:51
@oesteban oesteban added this to the 1.4.1 milestone Dec 21, 2019
@oesteban oesteban merged commit 9248d8f into nipy:master Dec 29, 2019
@oesteban oesteban deleted the maint/refactor-docs-build branch December 29, 2019 23:04
@effigies effigies mentioned this pull request Jan 6, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant