REL: 1.2.2 #3015
Merged
REL: 1.2.2 #3015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Sep 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
==========================================
- Coverage 67.5% 64.36% -3.15%
==========================================
Files 344 344
Lines 44029 44029
Branches 5551 5551
==========================================
- Hits 29722 28338 -1384
- Misses 13559 14535 +976
- Partials 748 1156 +408
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
=========================================
- Coverage 67.5% 67.5% -0.01%
=========================================
Files 344 344
Lines 44045 44028 -17
Branches 5552 5551 -1
=========================================
- Hits 29733 29721 -12
+ Misses 13568 13567 -1
+ Partials 744 740 -4
Continue to review full report at Codecov.
|
|
@djarecka Oscar didn't ping you, but if you get a chance to verify that we're not breaking the tutorials, could you do that? Or show one of us how you do that? |
Output of ``python tools/update_zenodo.py``: ``` No entry to sort: Victor Férat No entry to sort: Martin No entry to sort: Isaiah Norton No entry to sort: Niklas Förster No entry to sort: daniel glen No entry to sort: rciric No entry to sort: Kirstie Whitaker No entry to sort: hstojic No entry to sort: Gio Piantoni No entry to sort: Jonathan R. Williford No entry to sort: Hao No entry to sort: Fred Mertz No entry to sort: Murat Bilgel No entry to sort: Kevin Sitek No entry to sort: Ami Tsuchida No entry to sort: Abel González No entry to sort: Michiel Cottaar No entry to sort: Daniel Brenner ```
|
Nothing to do at conda forge except check that it passes. Once you release, it'll update with the new hash and we can merge. Also, don't know if I mentioned it, but you should push an annotated tag before making the GitHub release. |
|
@oesteban I've started a job here: https://circleci.com/workflow-run/37f1cebd-69f8-40eb-80a5-76e001e55b3b. It should run on the latest master, so if it passes, we're set. |
|
Should I push the annotated tag before merging this PR? |
|
No. Merge, then: git fetch upstream
git checkout upstream/master
git tag -a 1.2.2 # -s if you want to sign with a GPG key
git push upstream 1.2.2For the tag message, I just copy the changelog, minus any Markdown stuff. e.g. |
|
If you mess up the tag, you can always just |
|
I cancelled the Circle and Travis builds for the tag. You can delete the tag on the repo with: |
effigies
reviewed
Sep 7, 2019
| @@ -1,3 +1,17 @@ | |||
| 1.2.2 (September 05, 2019) | |||
There was a problem hiding this comment.
@oesteban If you're pushing a new tag, you might want to update the date before tagging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prep for 1.2.2 release, targeting Friday, September 6.
Please add any issues you want to see included in the following release to the upcoming 1.2.3 milestone targetting September 23.
Release checklist
nipype/info.pyanddoc/conf.pydoc/documentation.rstwith previous releasesUncredited authors
The following authors have contributed, but not added themselves to the
.zenodo.jsonfile. If you would like to be an author on Zenodo releases, please add yourself or comment with your preferred publication name, affiliation and ORCID. If you would like to stop being spammed whenever I'm the one doing releases, let me know, and I'll add you to a blacklist.No entry to sort: Victor Férat (@vferat)
No entry to sort: Murat Bilgel (@bilgelm)Acknowledgment