Skip to content

MAINT: Add python_requires to package metadata #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ jobs:
name: Check pypi preconditions
command: |
pip install --upgrade pip twine future wheel readme_renderer setuptools
python setup.py check -r -s
python setup.py sdist bdist_wheel
twine check dist/*
- run:
name: Validate Python 2 installation
command: |
Expand All @@ -368,6 +368,14 @@ jobs:
pip install dist/nipype-*-py2.py3-none-any.whl
# Numpy should be upgraded to >= 1.15.3
test "$(pip show numpy | grep Version)" \> "Version: 1.15.2"
- run:
name: Check python_requires prevents installation on Python 3.3
command: |
pyenv install 3.3.7
pyenv local 3.3.7
FAIL=false
pip install dist/nipype-*-py2.py3-none-any.whl || FAIL=true
$FAIL
- store_artifacts:
path: /home/circleci/nipype/dist

Expand Down
1 change: 1 addition & 0 deletions nipype/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def get_nipype_gitversion():
'Programming Language :: Python :: 3.7',
'Topic :: Scientific/Engineering'
]
PYTHON_REQUIRES = ">= 2.7, != 3.0.*, != 3.1.*, != 3.2.*, != 3.3.*"

description = 'Neuroimaging in Python: Pipelines and Interfaces'

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ def main():
author_email=ldict['AUTHOR_EMAIL'],
platforms=ldict['PLATFORMS'],
version=ldict['VERSION'],
python_requires=ldict['PYTHON_REQUIRES'],
install_requires=ldict['REQUIRES'],
setup_requires=SETUP_REQUIRES,
provides=ldict['PROVIDES'],
Expand Down