Skip to content

[FIX] MapNodes fail when MultiProcPlugin passed by instance #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

oesteban
Copy link
Contributor

When calling workflow.run(plugin=MultiProcPlugin()), MapNodes are set the use_plugin member that is not pickleable if plugin is a MultiProcPlugin object.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

When calling ``workflow.run(plugin=MultiProcPlugin())``, MapNodes are set the ``use_plugin`` member that is not pickleable if ``plugin`` is a ``MultiProcPlugin`` object.
@codecov-io
Copy link

Codecov Report

Merging #2786 into master will decrease coverage by 3.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
- Coverage   67.49%   64.11%   -3.39%     
==========================================
  Files         341      339       -2     
  Lines       43285    43236      -49     
  Branches     5364     5361       -3     
==========================================
- Hits        29214    27719    -1495     
- Misses      13369    14447    +1078     
- Partials      702     1070     +368
Flag Coverage Δ
#smoketests ?
#unittests 64.11% <100%> (-0.78%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/engine/workflows.py 72.37% <100%> (-6.71%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 49.59% <0%> (-30.9%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
nipype/interfaces/spm/base.py 58.41% <0%> (-29.05%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.99%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb8a16...54718c7. Read the comment docs.

@oesteban
Copy link
Contributor Author

Given the very low risk of this patch, I'll go ahead and merge it.

@oesteban oesteban merged commit fa3e2b8 into nipy:master Nov 22, 2018
@oesteban oesteban deleted the fix/plugin-by-instance branch November 22, 2018 01:12
@oesteban oesteban restored the fix/plugin-by-instance branch November 22, 2018 05:23
@effigies effigies added this to the 1.1.6 milestone Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants