Skip to content

IP Groups in override-rules #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

kudriavitsky
Copy link

Proposed changes

Added documentation for ip-groups in policy override-rules.

@kudriavitsky kudriavitsky requested a review from a team as a code owner May 8, 2025 13:04
Copy link

github-actions bot commented May 8, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nap-waf NGINX App Protect WAF labels May 8, 2025
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: made some edit suggestions to simplify the language.

I'm unsure if "IP Groups" is a proper noun as a product feature, which would affect the usage of the term in this context.

@kudriavitsky You'll need to sign the CLA once for all work in this repository.

@kudriavitsky
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:

I have hereby read the F5 CLA and agree to its terms

1 out of 2 committers have signed the CLA.✅ (ADubhlaoich)[https://github.com/ADubhlaoich]❌ @kudriavitskyYou can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

I have hereby read the F5 CLA and agree to its terms

@mjang
Copy link
Contributor

mjang commented May 13, 2025

@kudriavitsky One of the limitations of the CLA bot is that it requires that you type in the message, by itself, in a single comment. (I've tried editing the messages of others to get by the CLA bot, and that led to other errors. So please try again....

I have hereby read the F5 CLA and agree to its terms

@kudriavitsky
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of trivial suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nap-waf NGINX App Protect WAF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants