-
Notifications
You must be signed in to change notification settings - Fork 83
IP Groups in override-rules #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
add IP Groups
add IP Groups in Policy Override Rules Conditions
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: made some edit suggestions to simplify the language.
I'm unsure if "IP Groups" is a proper noun as a product feature, which would affect the usage of the term in this context.
@kudriavitsky You'll need to sign the CLA once for all work in this repository.
content/includes/nap-waf/config/common/ip-groups-override-rules.md
Outdated
Show resolved
Hide resolved
content/includes/nap-waf/config/common/ip-groups-override-rules.md
Outdated
Show resolved
Hide resolved
content/includes/nap-waf/config/common/ip-groups-override-rules.md
Outdated
Show resolved
Hide resolved
content/includes/nap-waf/config/common/ip-groups-override-rules.md
Outdated
Show resolved
Hide resolved
content/includes/nap-waf/config/common/ip-groups-override-rules.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
I have hereby read the F5 CLA and agree to its terms
I have hereby read the F5 CLA and agree to its terms |
@kudriavitsky One of the limitations of the CLA bot is that it requires that you type in the message, by itself, in a single comment. (I've tried editing the messages of others to get by the CLA bot, and that led to other errors. So please try again.... I have hereby read the F5 CLA and agree to its terms |
I have hereby read the F5 CLA and agree to its terms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of trivial suggested changes.
Co-authored-by: Mike Jang <[email protected]>
…s.md Co-authored-by: Mike Jang <[email protected]>
Proposed changes
Added documentation for ip-groups in policy override-rules.