Skip new summary tests on RX session #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this here for traceability neo4j-drivers/testkit#653 |
robsdedude
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Smells like a regex, glob matcher, or similar predicate could simplify the code a little. No blocker though.
There was a problem hiding this comment.
I like the idea, but it'd take a rewrite of the skipping part that would make this significantly bigger PR. Worth putting on my backlog, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RX session handles sending DISCARDS slightly differently than other drivers, which breaks some new tests being added to testkit. This skips those new tests on the rx driver until a more elegant solution is found