PYTHON-3142 Stop using $where in test_maxConnecting #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested review from
blink1073
and removed request for
blink1073
|
Is there a way to add a unittest to ensure that this test does not fail within |
I don't want to do that because it would make this test slower and more flakey. We could "ensure the test passes at least once in n iterations" but I also don't want to do that since it would hide legitimate server or driver bugs (it would have masked this server regression). |
ShaneHarvey
added a commit
that referenced
this pull request
Feb 23, 2022
(cherry picked from commit 8496ed4)
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Feb 25, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing $where fixes the test failures.