Skip to content

PYTHON-3088 [4.0] Test rapid releases with load balancers #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2022
Merged

PYTHON-3088 [4.0] Test rapid releases with load balancers #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0afa1f
PYTHON-3088 [v3.13] Update load balancer tests to support dedicated l…
juliusgeo Feb 17, 2022
9b39bf1
shouldn't change linux runner version
juliusgeo Feb 17, 2022
ab3f362
remove other instance where we don't need LOAD_BALANCER: true
juliusgeo Feb 17, 2022
dbf91d8
remove references to service ID
juliusgeo Feb 18, 2022
7adf4d8
remove version that was added erroneously
juliusgeo Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,12 +1714,9 @@ tasks:
commands:
- func: "bootstrap mongo-orchestration"
vars:
VERSION: "latest"
TOPOLOGY: "sharded_cluster"
LOAD_BALANCER: true
- func: "run load-balancer"
vars:
LOAD_BALANCER: true
- func: "run tests"
# }}}
- name: "coverage-report"
Expand Down Expand Up @@ -1920,6 +1917,10 @@ axes:
display_name: "MongoDB latest"
variables:
VERSION: "latest"
- id: "rapid"
display_name: "MongoDB rapid"
variables:
VERSION: "rapid"

# Choice of Python runtime version
- id: python-version
Expand Down Expand Up @@ -2636,7 +2637,7 @@ buildvariants:
- matrix_name: "load-balancer"
matrix_spec:
platform: ubuntu-18.04
mongodb-version: ["5.0", "latest"]
mongodb-version: ["rapid", "latest"]
auth-ssl: "*"
python-version: ["3.6", "3.7", "3.8", "3.9", "pypy3.6", "pypy3.7"]
loadbalancer: "*"
Expand Down
5 changes: 0 additions & 5 deletions pymongo/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,6 @@ def _hello(self, cluster_time, topology_version, heartbeat_frequency, all_creden
cmd["speculativeAuthenticate"] = auth_ctx.speculate_command()

doc = self.command("admin", cmd, publish_events=False, exhaust_allowed=awaitable)
if not self.opts.load_balanced:
doc.pop("serviceId", None)
hello = Hello(doc, awaitable=awaitable)
self.is_writable = hello.is_writable
self.max_wire_version = hello.max_wire_version
Expand Down Expand Up @@ -673,9 +671,6 @@ def _next_reply(self):
unpacked_docs = reply.unpack_response()
response_doc = unpacked_docs[0]
helpers._check_command_response(response_doc, self.max_wire_version)
# Remove after PYTHON-2712.
if not self.opts.load_balanced:
response_doc.pop("serviceId", None)
return response_doc

def command(
Expand Down