Skip to content

BUMP 3.12.0b0 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Conversation

prashantmital
Copy link
Contributor

No description provided.

@prashantmital prashantmital changed the title Update changelog BUMP 3.12.0b0 Mar 31, 2021
client side field level encryption (`PYTHON-2472`_).
- Fixed a bug that prevented PyMongo from retrying writes after
a ``writeConcernError`` on MongoDB 4.4+ (`PYTHON-2452`_).
- Fixed a memory leak caused by failing SDAM monitor checks on Python 3 (`PYTHON-2433`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of these were fixed in 3.11.3 (or earlier 3.11 releases). Can we remove them?

Copy link
Member

@ShaneHarvey ShaneHarvey Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also copy the 3.11.2 and 3.11.3 Changelog entries to this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I was a bit confused about how we want this to be reflected... Since the git histories diverged and are not common between 3.11.x and 3.12.x I thought duplicating everything in 3.12.x was the way to go... Doesn't adding the 3.11.x sections here seem to imply that 3.12.0b0 builds on the source tree of 3.11.3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog shouldn't need to match the git branch history all the time. If users want a full breakdown of all the tickets they can look at the jira issues or git commits but I don't think we need to duplicate changelog entries for bugs fixed log ago. It would be different if 3.12.0 was released and we needed to fix the same bug in 3.11.4 and 3.11.1. In that case the bug fix would go under both releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good.

@prashantmital prashantmital merged commit 0729a1c into mongodb:v3.12 Mar 31, 2021
@prashantmital prashantmital deleted the update-312-changelog branch March 31, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants